Vegard Engen
3cc169713e
Make AfterEach cleanup blocks more robust by only attempting to delete resources if they exist. This prevents test failures when resources have already been deleted or don't exist. Changes: - Check if resource exists before attempting deletion - Only call Delete if Get succeeds (err == nil) - Applied to all 5 controller test files This fixes intermittent test failures in GitHub Actions where AfterEach was failing with resource not found errors.
85 lines
2.6 KiB
Go
85 lines
2.6 KiB
Go
/*
|
|
Copyright 2025 Vegard Engen.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package controller
|
|
|
|
import (
|
|
"context"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
"k8s.io/apimachinery/pkg/api/errors"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"sigs.k8s.io/controller-runtime/pkg/reconcile"
|
|
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
|
|
unifiv1beta1 "github.com/vegardengen/unifi-network-operator/api/v1beta1"
|
|
)
|
|
|
|
var _ = Describe("PortForward Controller", func() {
|
|
Context("When reconciling a resource", func() {
|
|
const resourceName = "test-resource"
|
|
|
|
ctx := context.Background()
|
|
|
|
typeNamespacedName := types.NamespacedName{
|
|
Name: resourceName,
|
|
Namespace: "default", // TODO(user):Modify as needed
|
|
}
|
|
portforward := &unifiv1beta1.PortForward{}
|
|
|
|
BeforeEach(func() {
|
|
By("creating the custom resource for the Kind PortForward")
|
|
err := k8sClient.Get(ctx, typeNamespacedName, portforward)
|
|
if err != nil && errors.IsNotFound(err) {
|
|
resource := &unifiv1beta1.PortForward{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: resourceName,
|
|
Namespace: "default",
|
|
},
|
|
// TODO(user): Specify other spec details if needed.
|
|
}
|
|
Expect(k8sClient.Create(ctx, resource)).To(Succeed())
|
|
}
|
|
})
|
|
|
|
AfterEach(func() {
|
|
// TODO(user): Cleanup logic after each test, like removing the resource instance.
|
|
resource := &unifiv1beta1.PortForward{}
|
|
err := k8sClient.Get(ctx, typeNamespacedName, resource)
|
|
if err == nil {
|
|
By("Cleanup the specific resource instance PortForward")
|
|
Expect(k8sClient.Delete(ctx, resource)).To(Succeed())
|
|
}
|
|
})
|
|
It("should successfully reconcile the resource", func() {
|
|
By("Reconciling the created resource")
|
|
controllerReconciler := &PortForwardReconciler{
|
|
Client: k8sClient,
|
|
Scheme: k8sClient.Scheme(),
|
|
}
|
|
|
|
_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
|
|
NamespacedName: typeNamespacedName,
|
|
})
|
|
Expect(err).NotTo(HaveOccurred())
|
|
// TODO(user): Add more specific assertions depending on your controller's reconciliation logic.
|
|
// Example: If you expect a certain status condition after reconciliation, verify it here.
|
|
})
|
|
})
|
|
})
|