omitempty for NetworkIDs in destination

.gitea/workflows/docker-build.yaml

@@ -1,18 +0,0 @@
-name: Build & Push Linode Webhook
-
-on:
-  push:
-    branches:
-      - main
-jobs:
-  build:
-    runs-on: ubuntu-latest
-    steps:
-       - name: Install node and go
-         run: apk add nodejs go
-       - name: Check out repository code
-         uses: actions/checkout@v4
-       - name: Build
-         run: cd unifi && go build .
-        
-

go.mod

@@ -1,4 +1,4 @@
-module gitea.engen.priv.no/klauvsteinen/go-unifi
+module github.com/vegardengen/go-unifi
 
 go 1.21
 

unifi/account_test.go

@@ -5,7 +5,7 @@ import (
 	"testing"
 
 	"github.com/tj/assert"
-	"gitea.engen.priv.no/klauvsteinen/go-unifi/unifi"
+	"github.com/vegardengen/go-unifi/unifi"
 )
 
 func TestAccountMarshalJSON(t *testing.T) {

unifi/firewall_policy.go

@@ -7,42 +7,42 @@ import (
 
 type FirewallDestination         struct {
 		IPGroupID          string   `json:"ip_group_id"`
-		IPs                []string `json:"ips,omitempty"`
+		IPs                []string `json:"ips"`
 		MatchOppositeIPs   bool     `json:"match_opposite_ips"`
 		MatchOppositePorts bool     `json:"match_opposite_ports"`
 		MatchingTarget     string   `json:"matching_target"`
 		MatchingTargetType    string   `json:"matching_target_type"`
-		NetworkIDs         [] string   `json:"network_ids,omitempty"`
+		NetworkIDs         [] string   `json:"network_ids"`
-		Port               string   `json:"port,omitempty"`
+		Port               string   `json:"port"`
 		PortGroupID        string   `json:"port_group_id"`
 		PortMatchingType   string   `json:"port_matching_type"`
-		Regions            []string `json:"regions,omitempty"`
+		Regions            []string `json:"regions"`
 		ZoneID             string   `json:"zone_id"`
 	} 
 
 type FirewallSource struct {
-		ClientMacs            []string `json:"client_macs,omitempty"`
+		ClientMacs            []string `json:"client_macs"`
-		IPs                   []string `json:"ips,omitempty"`
+		IPs                   []string `json:"ips"`
 		MatchMac              bool     `json:"match_mac"`
 		MatchOppositeIPs      bool     `json:"match_opposite_ips"`
 		MatchOppositeNetworks bool     `json:"match_opposite_networks"`
 		MatchOppositePorts    bool     `json:"match_opposite_ports"`
-		MatchingTarget        string   `json:"matching_target,omitempty"`
+		MatchingTarget        string   `json:"matching_target"`
-		MatchingTargetType    string   `json:"matching_target_type,omitempty"`
+		MatchingTargetType    string   `json:"matching_target_type"`
 		NetworkIDs            []string `json:"network_ids,omitempty"`
-		Port                  string   `json:"port,omitempty"`
+		Port                  string   `json:"port"`
-		PortMatchingType      string   `json:"port_matching_type,omitempty"`
+		PortMatchingType      string   `json:"port_matching_type"`
-		ZoneID                string   `json:"zone_id,omitempty"`
+		ZoneID                string   `json:"zone_id"`
 	}
 
 type FirewallSchedule              struct {
 		Mode         string        `json:"mode"`
-		DateStart     string  `json:"date_start,omitempty"`
+		DateStart     string  `json:"date_start"`
-		DateEnd     string  `json:"date_end,omitempty"`
+		DateEnd     string  `json:"date_end"`
 		RepeatOnDays []string `json:"repeat_on_days"`
 		TimeAllDay   bool          `json:"time_all_day"`
-		TimeRangeStart string      `json:"time_range_start,omitempty"`
+		TimeRangeStart string      `json:"time_range_start"`
-		TimeRangeEnd string      `json:"time_range_end,omitempty"`
+		TimeRangeEnd string      `json:"time_range_end"`
 	}
 
 type FirewallPolicy struct {
@@ -66,11 +66,11 @@ type FirewallPolicy struct {
 	IPVersion             string `json:"ip_version"`
 	Logging               bool   `json:"logging"`
 	MatchIPSec            bool   `json:"match_ip_sec"`
-	MatchIPSecType        string `json:"match_ip_sec_type,omitempty"`
+	MatchIPSecType        string `json:"match_ip_sec_type"`
 	MatchOppositeProtocol bool   `json:"match_opposite_protocol"`
 	Name                  string `json:"name"`
-	OriginID              string `json:"origin_id,omitempty"`
+	OriginID              string `json:"origin_id"`
-	OriginType            string `json:"origin_type,omitempty"`
+	OriginType            string `json:"origin_type"`
 	Predefined            bool   `json:"predefined"`
 	Protocol              string `json:"protocol"`
 	Schedule              FirewallSchedule `json:"schedule"`

unifi/network_test.go

@@ -5,7 +5,7 @@ import (
 	"reflect"
 	"testing"
 
-	"gitea.engen.priv.no/klauvsteinen/go-unifi/unifi"
+	"github.com/vegardengen/go-unifi/unifi"
 )
 
 func TestNetworkUnmarshalJSON(t *testing.T) {

unifi/unifi.go

@@ -255,7 +255,7 @@ func (c *Client) do_versioned(ctx context.Context, version, method, relativeURL
 		c.csrf = resp.Header.Get("X-Csrf-Token")
 	}
 
-	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusCreated {
+	if resp.StatusCode != http.StatusOK {
 		errBody := struct {
 			Meta meta `json:"meta"`
 			Data []struct {